Update publisher image to nodejs22 #1760
Conversation
Updates publisher image so we use nodejs22. The previous nodejs20 image we were using were too old, and rolldown (required for new package tooling tsdown) wasn't able to be installed.
Summary of ChangesHello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the foundational Node.js runtime for the publishing process. By moving to Node.js 22, it resolves compatibility issues that prevented the installation of essential modern package tooling, specifically Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the publisher container's base image from Node.js 20 to Node.js 22 to support newer tooling. The change is straightforward. I've added one suggestion to pin the Node.js version in the Dockerfile to a specific version to improve build reproducibility.
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
2 participants
Updates publisher image so we use nodejs22. The previous nodejs20 image we were using were too old, and rolldown (required for new package tooling tsdown) wasn't being installed.
This PR also reverts #1759 which was the wrong fix.